Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Revise the membership withdrawal logic #145

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

holmir97
Copy link
Member

๐ŸŒˆ PR ์š”์•ฝ / Linked Issue

  • ํšŒ์›ํƒˆํ‡ด ๋กœ์ง์„ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ๋‹‰๋„ค์ž„, ์ด๋ฉ”์ผ ์ค‘๋ณต๊ฒ€์‚ฌ ๋กœ์ง์„ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค
  • ์ด์ œ ์œ ์ € ์Šค์ผ€์ค„๋Ÿฌ์—์„œ ์‚ญ์ œ๋œ ๋ฆฌ๋ทฐ ๊ฐœ์ˆ˜๋ฅผ ํ™•์ธํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
    close [hotfix] Revise the membership withdrawal logicย #144

๐Ÿ“Œ ๋ณ€๊ฒฝ ์‚ฌํ•ญ

๋””ํ…Œ์ผํ•œ ์ž‘์—… ๋‚ด์—ญ์„ ์ ์–ด์ฃผ์„ธ์š”.
์ฃผ์˜ํ•  ์‚ฌํ•ญ์ด ์žˆ๋‹ค๋ฉด ์ ์–ด์ฃผ์„ธ์š”.
๋ณ€๊ฒฝ์‚ฌํ•ญ (๋ชจ๋“ˆ ์„ค์น˜ ๋“ฑ)์ด ์žˆ๋‹ค๋ฉด ์ ์–ด์ฃผ์„ธ์š”.

โœ… PR check list

1. ์ œ๋ชฉ ์–‘์‹ ์ค€์ˆ˜ ํ™•์ธ

[feat] PR title

2. ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘๋™ ์Šคํฌ๋ฆฐ์ƒท

npm run mocha

โœ… After merge check list

1. ๋ฆด๋ฆฌ์ฆˆ ๋…ธํŠธ ๋ณ€๊ฒฝ

๋ฆด๋ฆฌ์ฆˆ ๋…ธํŠธ To Do์—์„œ Done์œผ๋กœ ์˜ฎ๊ธฐ๊ธฐ

2. ๋ธŒ๋žœ์น˜ ์‚ญ์ œ

@holmir97 holmir97 added ๐Ÿ”จ fix ์˜ค์ž‘๋™ ์ฝ”๋“œ ๋ฐ”๋กœ์žก๊ธฐ 1๏ธโƒฃ priority: high ์šฐ์„ ์ˆœ์œ„ ๋†’์Œ labels Apr 28, 2022
@holmir97 holmir97 added this to the v2.1.1 milestone Apr 28, 2022
@holmir97 holmir97 merged commit 5daff15 into develop Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃ priority: high ์šฐ์„ ์ˆœ์œ„ ๋†’์Œ ๐Ÿ”จ fix ์˜ค์ž‘๋™ ์ฝ”๋“œ ๋ฐ”๋กœ์žก๊ธฐ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hotfix] Revise the membership withdrawal logic
2 participants